Hello,
I've suggested some small changes which I've attached as patches. I also have some questions and comments:
On 3/30/25 1:11p, Carmine Margiotta wrote:> +;;; Gexp executables will be serialized on a program-file
> +(define (serialize-executable name value)
> + (if (string? value) value
> + (program-file (symbol->string name) value
> + #:module-path %load-path))
How will you serialize g-expressions? It seems that they are to be added to the store as scripts with 'program-file', but I can't figure out how to extract the file path from the resulting object; I tried in a REPL, program-file objects cannot be used as strings like this function seems to suggest, and none of the their properties seem to clearly give their location in the store.
Also, how are you testing your work? I asked in the IRC channel and they suggested spooling up a VM via 'guix system vm' with an operating-system definition containing the experimental service, but perhaps you have your own method.
From 0d2c72441d9b4a94aded6d53028d63b253f5e7ae Mon Sep 17 00:00:00 2001
Message-ID: <0d2c72441d9b4a94aded6d53028d63b253f5e7ae.1743381801.git.wongandj@icloud.com>
From: Andrew Wong <wongandj@icloud.com>
Date: Sun, 30 Mar 2025 15:16:27 -0400
Subject: [PATCH 1/5] home: services: hyprland(%default-hyprland-env): Fix
typo.
Change-Id: I7ade3bf3a9a550b246aa9db66f3cea626640c180
Signed-off-by: Carmine Margiotta <email@cmargiotta.net>
* gnu/packages/admin.scm (lrzsz)[arguments]<#:phases>{configure}:
Set CFLAGS to stop turning warnings into errors.
Fixes: guix/guix#5854
Change-Id: I0f74e8e4a81e4509c5fb69759511819e68ba31e3
* gnu/packages/prolog.scm (trealla): Switch to running the standard tests.
[native-inputs]: Delete it.
[arguments]: Adjust the test target to be test.
Running the valgrind memory checks is overkill for our purposes. Valgrind
should only be run in a local development workflow and not in our
CI. Switching to running the standard tests will also mimic what upstream runs
in their own CI for the Trealla project. Switching to running only the
standard tests also greatly reduces the time that it takes to run the full
Guix build for the trealla variable.
Change-Id: I912b85bfbe3fde03e6c0b98a47b2dbaa9b4b5d8a
* etc/teams.scm: Make rhou a member of teams python, science and c++.
Change-Id: I208d8158b746136495c9b61248e2be7331b4bae4
Signed-off-by: Andreas Enge <andreas@enge.fr>
To prevent redirection to the versioned maual, use devel on master branch.
* doc/htmlxref.cnf: Point GUIX to devel manual.
Change-Id: I6b2bf3b78ca5815ff49e6ebe50bc12383e64a7fd
* gnu/packages/prolog.scm (trealla): Update to 2.89.1 and apply formatting.
[native-inputs]: Remove xxd.
[arguments]: Set PREFIX and HOST_CC environment variables.
Remove install phase.
This update also installs the newly created man page for Trealla.
Change-Id: I2fb8e67af2ca075d0dd863a45763fec1483966ae
* gnu/packages/lisp-xyz.scm (sbcl-cl-posix-mqueue): Format to modern style.
[native-inputs]: Format to modern style.
[inputs]: Format to modern style.
Change-Id: I3ce9decc7a106bb98168137cdcbb218b48c25093
* gnu/packages/lisp-xyz.scm (sbcl-cl-posix-mqueue): Update to 0.1.3.
This uses the tagged release which is at the same commit as the direct commit
that was previously used.
Change-Id: I5e7c59a09da75c1fe377e2425a5e2ea28e94f20d
Partially reverts e642300195.
Only semver is a required dependency, zstd is optional.
* configure.ac: Remove check for Guile-zstd being available.
Change-Id: I1fe0fe77d0f15b1d383c890b46ce678402054efc
These were omitted from the configure script, leading to failure during the
build, instead of an earlier failure during ./configure.
Change-Id: I62a69eccf854acc1f7ae9a7aeb26897cf433478c
