From accb75c33bc1446551bc039a030c5c00757d0351 Mon Sep 17 00:00:00 2001 From: Nigko Yerden Date: Tue, 8 Apr 2025 11:30:24 +0500 Subject: [PATCH] services: tlp: Make destructor return #f on success. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * gnu/services/pm.scm (tlp-shepherd-service): Make destructor return #f on success. Destructor "should return #f if it is now possible again to start the service at a later point" (shepherd manual). Change-Id: Ic0d21d32af158da1ae940d9c32c05a3471767764 Signed-off-by: Ludovic Courtès --- gnu/services/pm.scm | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm index e0224377487..12f05b4b335 100644 --- a/gnu/services/pm.scm +++ b/gnu/services/pm.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2017 Mathieu Othacehe ;;; Copyright © 2024 Dariqq ;;; Copyright © 2024 Ian Eure +;;; Copyright © 2025 Nigko Yerden ;;; ;;; This file is part of GNU Guix. ;;; @@ -459,15 +460,17 @@ performance, balance_performance, default, balance_power and power.")) (define (tlp-shepherd-service config) (let* ((tlp-bin (file-append (tlp-configuration-tlp config) "/sbin/tlp")) - (tlp-action (lambda args + (tlp-action (lambda (return-value-on-success . args) #~(lambda _ - (zero? (system* #$tlp-bin #$@args)))))) + (if (zero? (system* #$tlp-bin #$@args)) + #$return-value-on-success + (not #$return-value-on-success)))))) (list (shepherd-service (documentation "Run TLP script.") (provision '(tlp)) (requirement '(user-processes)) - (start (tlp-action "init" "start")) - (stop (tlp-action "init" "stop")))))) + (start (tlp-action #t "init" "start")) + (stop (tlp-action #f "init" "stop")))))) (define (tlp-activation config) (let* ((config-str (with-output-to-string