bartronx7/guix
1
0
Fork 0
mirror of https://codeberg.org/guix/guix.git synced 2026-01-28 19:56:59 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

linux-container: Inhibit GC thread creation in child.

Browse source 
The `unshare' system call with `CLONE_NEWUSER' cannot be used in multithreaded
programs.  Guile VM's automatic GC thread creation used to lead to
nondeterministic failures in container creation, which uses this system call.

* gnu/build/linux-container.scm (run-container): Disable GC in child after
`(clone)' and re-enable after `(unshare)'.

Fixes: #1169
Change-Id: I9df5412102509c13f74ab9911f6f06c0152d0a4f
Signed-off-by: Maxim Cournoyer <maxim@guixotic.coop>
This commit is contained in:
W. Kosior 2025-10-15 16:18:23 +02:00 • committed by Maxim Cournoyer
parent 5373d3b9aa
commit 3966f76297
No known key found for this signature in database
GPG key ID: 1260E46482E63562
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gnu/build/linux-container.scm
View file

@ -266,6 +266,8 @@ that host UIDs (respectively GIDs) map to in the namespace."
(let ((flags (namespaces->bit-mask namespaces)))
(match (clone flags)
(0
;; Inhibit thread creation until after the unshare call.
(gc-disable)
(call-with-clean-exit
(lambda ()
(close-port parent)
@ -320,6 +322,7 @@ that host UIDs (respectively GIDs) map to in the namespace."
;; why unshare(CLONE_NEWUSER) can be used.
(let ((uid (getuid)) (gid (getgid)))
(unshare (logior CLONE_NEWUSER CLONE_NEWNS))
(gc-enable)
(when (file-exists? "/proc/self")
(initialize-user-namespace (getpid)
host-uids